search

nadeemlab / SPT

Spatial profiling toolbox for spatial characterization of tumor immune microenvironment in multiplex images
https://oncopathtk.org
Other
21 stars 2 forks source link

Rename `cg-gnn` submodule to `graphs` #277

Closed CarlinLiao closed 11 months ago

CarlinLiao commented 11 months ago

Per #272, the cggnn submodule should be renamed to graphs to reflect the change in its responsibilities and disambiguate from the cg-gnn model.

This would also future-proof against a potential expansion to creating tissue/region graphs in addition to cell graphs that I think we'd want to do, but that's outside the scope of this issue.

jimmymathews commented 11 months ago

I don't think you need a separate issue for this. This is clearly "per #272". Many of the other recently created issues are also part of a single work item. Let's consolidate them into one place.

CarlinLiao commented 11 months ago

I'd like to create, test, and merge these as individual PRs instead of one big PR. Would you recommend doing it all in one go?

jimmymathews commented 11 months ago

Yes. They need to exhibit cohesion in order to be evaluated.

CarlinLiao commented 11 months ago

Rolled back into #272.