search

nadilhassan / humhub-news-module

This module allows you to publish news stories to any Space - you can upload a photo and select a layout.
15 stars 8 forks source link

Can't edit news image anymore. #1

Open buddh4 opened 8 years ago

buddh4 commented 8 years ago

When I try to edit an existing news entry, there is no way to change the image anymore, I don't see the image upload part. Only If I created the news without an image and want to edit it the image upload part is present. missingimageupload

nadilhassan commented 8 years ago

Yes, you are not able to edit, It's a limitation in this version, Hope we would integrate this feature on next release!

buddh4 commented 8 years ago

ah ok ;) perhaps you should mark this post with an enhancement label or something.

nadilhassan commented 8 years ago

OH Sorry

nadilhassan commented 8 years ago

Yes, This is an enhancement.

buddh4 commented 8 years ago

Hi nadil, just curious, is there a reason why the image can't be edited? Perhaps I can help you with this issue. I personally would expect beeing able to edit the content and image ;)

nadilhassan commented 8 years ago

The reason is there is no issue with editing the image but after editing the image If I save then the JSON output is printing on browser.So that why I removed the image editing option. OK . If you can tell me what way that to be done I hope I can do that Thank You Very Much

buddh4 commented 8 years ago

could you commit the version with your json problem and I'll have a look if this is not to much effort?

nadilhassan commented 7 years ago

HI! I am sorry for the late response, mess up with lot works. I have created a gist of the files which causes the problem in editing image. URL : https://gist.github.com/nadilhassan/49e11da9b920fbb7f3817b2c22fc2374 Please bear with the code structure! Sorry

nadilhassan commented 7 years ago

HI I have done updated the image editing feature Can you please check this

buddh4 commented 7 years ago

Hi, thanks will have a look soon!

buddh4 commented 7 years ago

Hi Nadil, sorry did not forget this, but we have no time till the v1.2 release. I would suggest we'll release this after the v1.2, since the marketplace will open anyways. And I think the mdoule will need some alignments for v1.2.

nadilhassan commented 7 years ago

HI It's OK.. I can see that you guys are working hard. Great! No worries will publish it after the v1.2. BTW what are the alignments needed?

buddh4 commented 7 years ago

Perhaps in the stream I can help you with this, we'll also write a migration guide for module migrations.

001101 commented 7 years ago

Guides would be great!!