search

nadilhassan / humhub-news-module

This module allows you to publish news stories to any Space - you can upload a photo and select a layout.
15 stars 8 forks source link

File and Data cleanup #3

Closed buddh4 closed 7 years ago

buddh4 commented 7 years ago

We have to get sure all data is removed when for example the module is disabled or space is removed, is there a reason you removed the following lines:

https://github.com/nadilhassan/newsmodule/blob/master/Module.php#L45

Furthermore you'll have to get sure your files are removed when your news are deleted.

nadilhassan commented 7 years ago

Yes, It will be done without those codes, That was for testing purpose Thanks

nadilhassan commented 7 years ago

I have re-check that with database tables, without those commented codes , the contents are removed (from disable function).

buddh4 commented 7 years ago

But have you also tested if the files and file entries are removed? This should be done in the afterDelete function of your Activerecord.

nadilhassan commented 7 years ago

I am sorry, I didn't, How can I delete the files which are associated with news? By getting the news image file guid and search for that guid with file and deleting it?

buddh4 commented 7 years ago

https://github.com/humhub/humhub-modules-custom-pages/blob/master/modules/template/models/TemplateContentActiveRecord.php#L152