search

nadjieb / cpp-mjpeg-streamer

C++ MJPEG over HTTP Library
MIT License
139 stars 39 forks source link

Graceful shutdown from url #1

Closed leonitousconforti closed 4 years ago

leonitousconforti commented 4 years ago

I find myself having to crtl-c to exit the program every time which does not allow opencv to properly release the capture or, if gstreamer is being used, for gstreamer to properly clean-up. Instead, why not add a hard coded URL that when you visit it it breaks from the loop/cleans up/shuts down etc.

kamalnadjieb commented 4 years ago

Hi @leonitousconforti , thank you for this Pull Request. I think that's a good idea but right now I have several things to do outside this project. Actually I have plan to make this project testable with proper CI and write a proper Contribution Guide. Maybe for now you can resolve the conflicts first because several days ago I add some CMake integration to this project. I will take a look at it in detail next week. Thank you.

kamalnadjieb commented 4 years ago

Wow @leonitousconforti thank you for your fast response. I will accept this PR. Thank you.