search

nadrad / h-m-m

Hackers Mind Map
GNU General Public License v3.0
1.89k stars 53 forks source link

Added more support for MacOS in install script #37

Closed gloof11 closed 1 year ago

gloof11 commented 2 years ago

I added a check for Homebrew, and if it exists, gives the option to install the corresponding dependencies.

nadrad commented 2 years ago

Thanks, but xclip and xsel are Linux requirements; if I understand it correctly, Mac always has pbcopy and pbpaste, and those are what h-m-m uses when detects a Mac. Maybe you can double-check and let me know.

gloof11 commented 2 years ago

You're right! The only thing the install script doesn't do is check if the system is a Mac. That's why it wasn't working. I'll fix the script then push to the branch again.

gloof11 commented 2 years ago

I had to change the interpreter to bash. It was the only way I could get the OS detection to work. Also, I made sure the script changed permissions on the binary so it was executable by users other than root.

mattiasbonte commented 1 year ago

Can this be merged?

nadrad commented 1 year ago

But it still seems to be requiring xclip, xsel, or wl-clipboard for Mac (lines 31 to 39).