search

nadrino / cpp-generic-toolbox

C++ Generic Toolbox is a header-only namespace which aims at being included in any cpp project. This toolbox gathers a collection of function which aims at simplifying the management of common objects.
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

GenericToolbox.Root.h ROOT_VERSION fix needed #27

Open JacekHoleczek opened 4 hours ago

JacekHoleczek commented 4 hours ago

The cpp-generic-toolbox/include/GenericToolbox.Root.h file contains:

#if ROOT_VERSION_CODE >= ROOT_VERSION(6,28,04)
    return gDirectory.fValue->load();
#elif ROOT_VERSION_CODE >= ROOT_VERSION(6,23,02)
    return gDirectory.fValue.load();
#else

I do not know which ROOT versions allow "gDirectory.fValue.load()" but the "operator->" is also needed for "ROOT_VERSION(6,26,14)" (I do not have here any previous ROOT versions to test it further, sorry).

nadrino commented 4 hours ago

It could that the 6.28 was chosen as it was installed on my computer and figured out there was a problem with this particular version.

Perhaps we could find the exact version where the -> is required