search

naeem2290 / pokemon

0 stars 0 forks source link

Api endpoint will come from environment file #4

Open muhammadawaisshaikh opened 5 days ago

muhammadawaisshaikh commented 5 days ago

there should be an environment file from which base url of a backend server will be used, currently, hardcoded url is used in the service, which is a bad practice

naeem2290 commented 5 days ago

Yes @muhammadawaisshaikh this is an improvement, Actually I don't find this app to go to production and we have something environment specific here. Just one API needs to be integrated that's why I used that directly.

But yes that is something that can be improved.

muhammadawaisshaikh commented 5 days ago

Always consider test as a prod grade app, interviewer is considering your test as a full fledged product. But that’s ok