naelstrof / KoboldKare

A public repo for the game KoboldKare
Other
86 stars 97 forks source link

Fixes the issue that happens when you have many equipment mods #323

Closed TwistedFlog closed 5 months ago

TwistedFlog commented 5 months ago

When you have a lot of equipment mods, if you use the /equip command you get the wrong equipment, this can also affect mods equipments.

The easiest way to replicate this issue is by subscribing to every mod in the Steam workshop that contain equipments and try to equip equipments from the base game with the /equip command

With this fix that no longer happens but if you have a mod with duplicate equipment or equipments with the same name as other equipment mods you will not be able to load that or those mods in the mod list.

naelstrof commented 5 months ago

Instead of using raw strings for the networked portions of the equipment, they probably should be shorts. They are bytes because they are synced with every "update" that photon sends. It's not delta compressed-- so strings will certainly be too much info. A short would be acceptable instead.