naelstrof / KoboldKare

A public repo for the game KoboldKare
Other
86 stars 97 forks source link

Custom Reagents MaxEnergy issue #339

Open Shurutsue opened 3 months ago

Shurutsue commented 3 months ago

https://github.com/naelstrof/KoboldKare/blob/b648607fa14fa42fd5d2b1ab22bb47f5ae1baa20/Assets/KoboldKare/Scripts/Reagents/ReagentEffects/MaxEnergyReagentEffect.cs#L9

Due to the conversion to a byte (even though it actually is a float), it'll require a full unit of change. This was an oversight on my part when I made the pull-request, attempting to not differ too much from existing reagents, so unless a floating point value would hinder the UI (or otherwise something) this should likely be changed to allow more freedom.

Unless I forget, I'll make a pull request in a bit, referencing this issue, after testing to ensure it doesn't break with the Display of energy, or otherwise throw an error.