search

naelstrof / maim

maim (make image) takes screenshots of your desktop. It has options to take only a region, and relies on slop to query for regions. maim is supposed to be an improved scrot.
Other
2.13k stars 78 forks source link

Undocumented dependency on EGL #133

Open kozross opened 6 years ago

kozross commented 6 years ago

CMake doesn't check for this, which can give you a nasty surprise like this:

[koz@Sebastian slop]$ make -j4
Scanning dependencies of target slopy
[  6%] Building CXX object CMakeFiles/slopy.dir/src/mouse.cpp.o
[ 13%] Building CXX object CMakeFiles/slopy.dir/src/x.cpp.o
[ 20%] Building CXX object CMakeFiles/slopy.dir/src/keyboard.cpp.o
[ 26%] Building CXX object CMakeFiles/slopy.dir/src/slopstates.cpp.o
[ 33%] Building CXX object CMakeFiles/slopy.dir/src/resource.cpp.o
[ 40%] Building CXX object CMakeFiles/slopy.dir/src/slop.cpp.o
[ 46%] Building CXX object CMakeFiles/slopy.dir/src/rectangle.cpp.o
In file included from /home/koz/slop/src/framebuffer.hpp:29:0,
                 from /home/koz/slop/src/window.hpp:40,
                 from /home/koz/slop/src/slop.cpp:19:
/home/koz/slop/src/shader.hpp:32:21: fatal error: EGL/egl.h: No such file or directory
kozross commented 6 years ago

Just realized this is an issue with slop, not maim. Sorry about that - please feel free to close or relocate this issue.

issmirnov commented 6 years ago

I made a page at https://github.com/naelstrof/maim/wiki/Installation. Can you take a look and help out?

kozross commented 6 years ago

@issmirnov I'll comment here instead of replicating to all my issues. That seems fine, but I would 'spell out' the slop deps as well (as a list). I'd also add any version restrictions (especially upper bounds, as lower ones tend not to be as much a problem) to the libraries you require, as well as making both the maim and slop deps actual lists:

Otherwise, seems good by me.

issmirnov commented 6 years ago

Awesome. The page is open to edits - please feel free. I'm currently travelling so will be away for a while. As far as version numbers go, I have no idea - I'm not one of the developers.

kozross commented 6 years ago

@issmirnov OK, I might well do that soon. Hopefully one of the devs can chime in for the rest. Thanks for your efforts!

naelstrof commented 6 years ago

Slop's some pretty old software now, I've been lazily adding dependencies as needed. (I wasn't sure that EGL was another dependency since on Arch it's packaged with mesa. Sorry about that!)

The arch dependency list is pretty clear, besides for that discrepancy, you could check that out to get a pretty good base list: https://www.archlinux.org/packages/community/x86_64/slop/

There's an old list of slop dependencies for Ubuntu in https://github.com/naelstrof/slop/issues/52 which might help also!