search

naelstrof / maim

maim (make image) takes screenshots of your desktop. It has options to take only a region, and relies on slop to query for regions. maim is supposed to be an improved scrot.
Other
2.15k stars 78 forks source link

catch all C++ exceptions and print error message #224

Closed foxpy closed 3 years ago

foxpy commented 3 years ago

Before this commit, maim did not catch every exception, so sometimes it could print scary message into terminal. Now the message looks a bit less scary :)

The changes introduced are valid portable C++11 as descibed here: https://en.cppreference.com/w/cpp/error/current_exception

I decided to do this PR after I have seen #191: because exception have not been caught, user erroneously decided maim has crashed and submitted this funny issue.

foxpy commented 3 years ago

I guess after merging #226 this pull request is irrelevant now. @naelstrof your thoughts?

naelstrof commented 3 years ago

I guess after merging #226 this pull request is irrelevant now. @naelstrof your thoughts?

Oh gosh I'm so sorry, I've really been letting this repo slide because I haven't had equipment that actually runs linux laying around. I've only recently got some dedicated machines running linux again and can actually review code. Your pull request just wasn't in a window where I was able to review it.