search

naelstrof / maim

maim (make image) takes screenshots of your desktop. It has options to take only a region, and relies on slop to query for regions. maim is supposed to be an improved scrot.
Other
2.15k stars 78 forks source link

Add WebP support #233

Closed llenck closed 3 years ago

llenck commented 3 years ago

Add support for encoding as WebP, for reasons like in #190. I figured since WebP can be lossy or lossless, it'd be good to do lossy for quality settings 0-9 and lossless for quality '10'.

I tested building/running this on arch linux with the PKGBUILD from your maim-git package with 'libwebp' added to the dependency list, and it seems to work, and produce smaller file sizes than png/jpg (and better quality compared to jpg).

Please let me know if there are any design choices or technical issues that prevent this from getting merged, so I can try to fix them ;)

naelstrof commented 3 years ago

Looks pretty good. I'll review it tomorrow and try to make a new release. Nice job!

naelstrof commented 3 years ago

I've merged this pull request, feel free to make another pull request if you feel like some other changes seem necessary. What I saw was well within my quality standards. Thanks so much llenck and foxpy!