naemon / naemon-core

Networks, Applications and Event Monitor
http://www.naemon.io/
GNU General Public License v2.0
151 stars 63 forks source link

Add option -i to ignore config warnings. #464

Closed johanthoren closed 3 months ago

johanthoren commented 3 months ago

This is an attempt to improve reload speed in huge environments. If Warnings are not going to be acted upon, an option to skip checking for them during the pre-flight-check or when running a verification would save some seconds for really large environments.

nook24 commented 3 months ago

Hi @johanthoren, thanks for your contribution! Could you please provide some numbers about how many hosts and services you have and how much this change improved the restart performance?

Also the output of a Naemon startup with --enable-timing-point would be interesting.

johanthoren commented 3 months ago

Hi @johanthoren, thanks for your contribution! Could you please provide some numbers about how many hosts and services you have and how much this change improved the restart performance?

Also the output of a Naemon startup with --enable-timing-point would be interesting.

I will report back once I've convinced the customer to run this patch in the environment where we're trying to reduce the time it takes to reload, but it's likely going to be a few days or more before I can do so since it's in production.

johanthoren commented 3 months ago

BTW, I think the --ignore-warnings option makes sense to reduce the log size where needed even if the time saved is negligible.

johanthoren commented 3 months ago

The change didn't bring significant enough changes. To completely get rid of warnings filling up the logs changes would have to be made in more places than I anticipated, which might be considered a bit too much. So I'll close this pull request.