naemon / naemon-core

Networks, Applications and Event Monitor
http://www.naemon.io/
GNU General Public License v2.0
153 stars 63 forks source link

Inconsistent code/docs for host check_period #84

Closed julianbrost closed 8 years ago

julianbrost commented 10 years ago

The docs on host objects list check_period as a required attribute but Naemon starts fine (even without warnings) if it's not set. In this case I guess it works just like if the time period was set to 24x7.

For services there is a check at naemon/configuration.c:1505 but for hosts there is only a check at naemon/configuration.c:1585 which only checks whether the timeperiod is valid if any is given.

This behavior should either be changed or documented. There might be similar problems for other attributes but check_period was the only one I looked at.

ageric commented 10 years ago

On 2014-08-04 17:39, Julian wrote:

The docs on host objects list check_period as a required attribute but Naemon starts fine (even without warnings) if it's not set. In this case I guess it works just like if the time period was set to 24x7.

For services there is a check at naemon/configuration.c:1505 but for hosts there is only a check at naemon/configuration.c:1585 which only checks whether the timeperiod is valid if any is given.

This behavior should either be changed or documented. There might be similar problems for other attributes but check_period was the only one I looked at.

check_period isn't required, and if one isn't supplied 24x7 will be used. I'll make a note to amend the docs.

/Andreas

catharsis commented 8 years ago

I've opened https://github.com/naemon/naemon.github.io/issues/59 to track this documentation update instead. Thanks for reporting it @julianbrost, and sorry for the late feedback!