search

naemon / naemon-livestatus

Naemon - Livestatus Eventbroker Module
GNU General Public License v2.0
26 stars 30 forks source link

Livestatus patches #1

Closed catharsis closed 10 years ago

catharsis commented 10 years ago

Here are a bunch of patches pertaining to both build system changes, unit test plumbing + a number of testcases, and unicode support in regular expressions.

ozamosi commented 10 years ago

I'd prefer it if pengi looked, too, as he's done way more livestatus hacking than me.

catharsis commented 10 years ago

@pengi Would you mind having a look-see?

pengi commented 10 years ago

Looked at it yesterday, but since the battery was out in my phone, and I have 2-factor on github, it was hard to answer :P

Looks good, as far as C++ can look good though. But since Anton has used valgrind, I trust nothing leaks with UnicodeString. (it doesn't look it should either, but I just think C++ references is nasty)