naemon / naemon-livestatus

Naemon - Livestatus Eventbroker Module
GNU General Public License v2.0
26 stars 30 forks source link

add dependency columns #47

Closed sni closed 5 years ago

sni commented 5 years ago

this pr add 4 new columns for hosts and services with dependency information.

and the same for services.

Signed-off-by: Sven Nierlein sven@nierlein.de

jacobbaungard commented 5 years ago

Looks good but I wonder if AuthUser is specified in the request, could it then be possible that the new columns could potentially include services which normally shouldn't be shown to the user? Especially if service_authorization is strict.

sni commented 5 years ago

Yes, that might reveil services or hosts which the current user is usually not allowed to see. But it will only reveil the hostname and the service description.

I just checked how other columns handle this, ex.: host parents and they filter the list according the permissions... I will add that as well.

sni commented 5 years ago

ok, i added authentication handling. thanks for the review.

sni commented 5 years ago

sorry, one more commit. I initially thougt service parents will be converted to service dependencies internally and show up in the dependency lists, but thats not the case. So adding another column for parents to catch them as well. At least its a very small commit :)