naev / naev

Naev is a 2d action/rpg space game that combines elements from the action, rpg and simulation genres.
https://naev.org
Other
836 stars 201 forks source link

Even more typos #1187

Closed Wuzzy2 closed 4 years ago

Wuzzy2 commented 4 years ago

While translating I found even more typos in the source strings:

onpon4 commented 4 years ago

Aramda or Armada?

These were all fixed a few days ago. There were a few cases of "Armada" being misspelled. 🕷️

"Oh, and she put in a nice bonus for you of %s credits for such a speedy delivery." Same.

This one is always going to be plural (in the realm of tens of thousands). The same goes for anything else counting credits, 1 credit is so small that we never talk about just one credit, so having a singular form is probably unnecessary. 🕷️

Missing period between sentences. Double exclamation mark

Another thing corrected in the last few days. I don't think the double exclamation mark is necessarily a problem (it can be useful sometimes even though it's non-standard), but incidentally we removed that recently as well. The dialog for that mission was written in a way that was supposed to sound desperate but came across as annoying instead. 🕵️

thnk space after opening quotation mark

Haha, more stuff we fixed a few days ago. We're starting to catch up to you on this. 😉 🕵️

double exclamation mark

I think this is a case where the double-exclamation mark is warranted. It's supposed to convey loud yelling. Nonstandard, but then again so is "?!".

We've fixed the rest in eebccd2. Thanks for the report!

🕵️

Wuzzy2 commented 4 years ago

This one is always going to be plural (in the realm of tens of thousands)

Ugh. You're clearly not knowing what you're knowing about. Grammatical number systems in other languages can be much more complex than singular/plural. Not going into much detail here, but for example, the type of word to use might depend in the last digit. The fact that the number can be in the tens of thausands is irrelevant. Thus, whenever there is something like “%d bananas”, the string should support “plural forms”, if possible.

Just trust someone who has been dealing with translation systems for years. :P

onpon4 commented 4 years ago

Oh yeah? Well in that case there's a lot more where that came from. There's dozens of uses of "%s credits" in mission Lua code.

I'll get started on that, though maybe we should have an issue about ngettext (non-)usage specifically.

🕵️

onpon4 commented 4 years ago

Here's a new issue: #1189

🕵️