Add Docker & Docker Compose and Update README

nafiesl / silsilah

A genealogy/family tree application, built with Laravel.

MIT License

577 stars 283 forks source link

Closed ilhamsyahids closed 2 months ago

ilhamsyahids commented 3 months ago

Close #104
Add docker and docker compose
- Run by
```
make run-docker
```
- Add php image with web server nginx
- Add with mysql image
- Add Makefile to simplify and shorten script
Update README
- Rename readme.md and readme.id.md to README.md and README.id.md respectively, I think its better to use convention name just like other OS project.
- Format and lint to comply with markdownlint
- Refactor installation steps

ilhamsyahids commented 3 months ago

Hi @nafiesl,

Can you please review this PR? thanks

ilhamsyahids commented 3 months ago

I was wondering do you have any plan to use travel-ci again in the future @nafiesl ? Since I saw in image build status here is not load properly

nafiesl commented 3 months ago

Hello @ilhamsyahids thanks for the PR, it's been 2 weeks, and I still did not have time to check on this. Sorry.

Regarding your question, no, we can change the CI service from Travis to Github action. You can add it to your PR if you have spare time.

By the way, we have a community group chat in telegram: https://t.me/silsilah_id you are very welcome if you join there.

Thanks @ilhamsyahids.

ilhamsyahids commented 3 months ago

we can change the CI service from Travis to Github action. You can add it to your PR if you have spare time.

I think its better to create another PR for updating the CI pipeline, since this PR is regarding the Dockerfile, @nafiesl