[PROPOSAL] Add Change Password Feature

nafiesl / silsilah

A genealogy/family tree application, built with Laravel.

MIT License

588 stars 284 forks source link

[PROPOSAL] Add Change Password Feature #14

Closed nafiesl closed 5 years ago

nafiesl commented 5 years ago

Currently our user don't have a feature to change password. We need a change password page for logged in user.

Change password flow :

User must be logged in
User click the "Change Password" menu/link
User must fill in the old password, new password and confirm new password.
System checks that old password is correct
If old password correct, save new password
Else, notify user that old password is incorrect.

Thanks.

tthompson899 commented 5 years ago

I’d like to take a stab at this one

nafiesl commented 5 years ago

Sure @tthompson899

cendekia commented 5 years ago

@nafiesl Sudah kelar ya Mas 😉

PR#15

tthompson899 commented 5 years ago

@cendekia Thanks for the update.

cendekia commented 5 years ago

@tthompson899 You're welcome, but I just realise that change password in the edit profile has different functionality (I'm a bit confused tho) and that cause Travis Ci failed :(

nafiesl commented 5 years ago

@cendekia thanks for the your PR, but i think change password feature on the profile edit page will be used by user manager to change their managed user's password. Actually i thought something like this will be better.

selection_18101807 41 18

You might want to take a look at this source code example, if it can help : ChangePasswordController.

Thanks.