nafiesl / silsilah

A genealogy/family tree application, built with Laravel.
MIT License
588 stars 284 forks source link

Invalid field format for year of death (yod) error. #25

Closed odeke closed 5 years ago

odeke commented 5 years ago

The user profile form with the year of death field only accepts a year e.g 2000 and the database only accepts date format. I solved this by changing the DB field for yod to an int in the users table.

nafiesl commented 5 years ago

Hi @odeke, thanks for your information. I will check that issue.

nafiesl commented 5 years ago

Hi @odeke, my apologize for late response. You were right, the yod column on users table is using date data type. I believe we need to use year data type instead of int.

I have fix this issue by changing the column data type to year in this commit: 3da89bf.

For existing database, you can run this sql command to apply this user table changes:

Don't forget to backup your database before run this sql command.

ALTER TABLE `users`
CHANGE COLUMN `yod` `yod` YEAR NULL DEFAULT NULL AFTER `dod`;
odeke commented 5 years ago

glad to help! Keep going, this is the neatest genealogy project out there. I will share my finished edition for your review.

On Wed, Jun 5, 2019 at 5:10 PM Nafies Luthfi notifications@github.com wrote:

Hi @odeke https://github.com/odeke, my apologize for late response. You were right, the yod column on users table is using date data type. I believe we need to use year data type instead of int.

I have fix this issue by changing the column data type to year in this commit: 3da89bf https://github.com/nafiesl/silsilah/commit/3da89bf5f2dd92e70f064ff30829676f6ebfb48f .

For existing database, you can run this sql command to apply this user table changes:

Don't forget to backup your database before run this sql command.

ALTER TABLE users CHANGE COLUMN yod yod YEAR NULL DEFAULT NULL AFTER dod;

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nafiesl/silsilah/issues/25?email_source=notifications&email_token=AAOYQ2CB6ZLZFNTWO2MFSNDPY7CL7A5CNFSM4HQFF73KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW72M2Q#issuecomment-499099242, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOYQ2AJGMEIYE3I6YH2OWDPY7CL7ANCNFSM4HQFF73A .

nafiesl commented 5 years ago

Sure @odeke, good to know you were creating one, too. I would be glad to wait. 👍