search

nafiesl / silsilah

A genealogy/family tree application, built with Laravel.
MIT License
600 stars 289 forks source link

User can edit family member #89

Closed xtrsyz closed 1 year ago

nafiesl commented 2 years ago

Hello @xtrsyz, would you mind adding unit tests regarding these changes? You may refer to the testing classes in this directory:

https://github.com/nafiesl/silsilah/tree/master/tests/Unit/Policies

I will review this PR after the testing has been added.

Thanks.

xtrsyz commented 2 years ago

sorry I don't understand how to add it. and I don't have time to learn it again. thanks.

nafiesl commented 2 years ago

Hi @xtrsyz, this project has been covered by automated testing. Every feature that has impacts on the database changes (create, edit or delete) must be covered by testing.

I can understand if you don't have time to write the tests. So I will leave this PR open until I or someone else can write tests for these changes.

Thanks for your idea and contribution. I appreciate your time working on this PR.

Current Progress

  1. Write logic that allows users to edit their own family members (new authorization)

Next TODO

  1. Write tests on policy objects covering the user authorizations to edit family members.
xtrsyz commented 1 year ago

Hi @nafiesl, i have create test unit for this. Thanks.