Module May Fail without Failing the Playbook

[naftulikay]

This happened:

TASK [degoss : emit debugging output] *************************************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "msg": "output info: {\n    \"changed\": false, \n    \"exception\": \"Traceback (most recent call last):\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 96, in <module>\\n    main()\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 88, in main\\n    rc, stdout, stderr = evaluate(module, test_file, fmt, executable, env_vars)\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 52, in evaluate\\n    environ_update=env_vars\\n  File \\\"/tmp/ansible_DzKBAW/ansible_modlib.zip/ansible/module_utils/basic.py\\\", line 2328, in run_command\\n  File \\\"/usr/lib/python2.7/os.py\\\", line 471, in __setitem__\\n    putenv(key, item)\\nTypeError: must be string, not bool\\n\", \n    \"failed\": false, \n    \"failed_when_result\": false, \n    \"module_stderr\": \"Traceback (most recent call last):\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 96, in <module>\\n    main()\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 88, in main\\n    rc, stdout, stderr = evaluate(module, test_file, fmt, executable, env_vars)\\n  File \\\"/tmp/ansible_DzKBAW/ansible_module_goss.py\\\", line 52, in evaluate\\n    environ_update=env_vars\\n  File \\\"/tmp/ansible_DzKBAW/ansible_modlib.zip/ansible/module_utils/basic.py\\\", line 2328, in run_command\\n  File \\\"/usr/lib/python2.7/os.py\\\", line 471, in __setitem__\\n    putenv(key, item)\\nTypeError: must be string, not bool\\n\", \n    \"module_stdout\": \"\", \n    \"msg\": \"MODULE FAILURE\", \n    \"rc\": 0\n}"
}

The module failure was caused by something else entirely, but for some reason, this isn't being reported as a failure.

Acceptance Criteria

• [x] degoss must clean up and then fail if the goss module failed.