Open iliana opened 6 years ago
I would like to do so. Are you in favor of me creating a more generic Docker image based on this one?
The current problem with this Docker image is that CircleCI can't use it as a build image for some reason that CircleCI gives an useless error and I cannot determine what changes need to be made to make it work. In my examples contributed to Crowbar, I simply use machine: true
and manually launch the Docker image to get builds working.
Would renaming this to naftulikay/lambda-crowbar
or something else be a good way of going about it? Basically verbatim clone of this repository, only would change the user name to be something like rust
.
A more generic image would be fine; it should have both the stable and nightly toolchains installed per https://github.com/ilianaw/rust-crowbar/pull/36.
I'm fine with you maintaining it, or merging your changes into the builder/ directory in ilianaw/rust-crowbar since that builder already doesn't work for most people.
Great, I will create a "fork" which is extremely generic and incorporates both stable and nightly. The Docker image will be automated on changes to the base image and on the rust
image so that when new versions land, the container will be updated with latest stable, nightly, etc.
If a user would like to pin to a specific version, they can do so using rustup
in their build steps.
Folks (including myself) have a lot of issues getting OpenSSL anything to build right for Lambda using the builder image linked to in crowbar's docs.
Ultimately the solution in my mind was to make this work with the lambci images, which you ultimately landed on.
Should we merge work and/or refer to your builder image in crowbar's docs?
(ref https://github.com/ilianaw/rust-crowbar/issues/20 https://github.com/ilianaw/rust-crowbar/pull/22)