nagadomi / nunif

Misc; latest version of waifu2x; 2D video to stereo 3D video conversion
MIT License
1.49k stars 141 forks source link

Like "Export Disparity" but without rgb images #246

Open 3gMan opened 1 week ago

3gMan commented 1 week ago

Hi nagadomi! Any chance we can get this option for those who use other methods for the final conversion? Not sure if it will give even a slight boost to speed, but the storage savings and less drive usage would be super helpful.

nagadomi commented 1 week ago

See #173 One thing to understand is that if you export only the depth from the video, the frame positions may not match the video (RGB frame) for various reasons. That is a more troublesome problem than disk space. If you want to use other video editing software, it is better to request a Depth Estimation add-on/plugin/custom-node for that software.

3gMan commented 1 week ago

So right now I am doing export disparity, and using just the resulting depth PNGs along with the original video in Resolve and it works perfect every time. I never touch the rgb frames except to delete them. Unless the act of creating the rgb frames somehow changes the number or order of the depth PNGs it should work fine, no?

nagadomi commented 1 week ago

Since iw3 always uses fixed(constant) FPS filter, the frame position may be shifted/skipped due to start duration, variable frame rate, changing frame rate etc. I have no way of knowing how other software handles frame positioning.


I am planning to add a checkbox for Advanced Settings to hide some settings options. I can add "Export (Depth Only)" in it. But remember, I do not recommend using that feature in my opinion.

3gMan commented 1 week ago

If you think it will definitely not work then that's ok. But if you think there is a chance, I will be happy to test it out! The only necessity is that the depth images come out in the correct order numbered the same way they are now.

Edit: And good idea about the advanced settings checkbox

nagadomi commented 1 week ago

When synchronization between depth and rgb frames is required: The method of outputting depth only can work or not, depending on the input video file and FPS setting. The method of outputting rgb and depth synchronously works fine in all cases. In my opinion, using unreliable methods to save disk space is not a good choice.

However, there are cases where only depth is required without need to synchronize with rgb frames, e.g. controlnet input. For this super logical reason I can add Export (Depth Only) feature.

3gMan commented 1 week ago

I'd like to give it a try and see what you are talking about if you don't mind