nagadomi / waifu2x

Image Super-Resolution for Anime-Style Art
http://waifu2x.udp.jp/
MIT License
27.33k stars 2.71k forks source link

Download on Firefox 97.0 creates a file that says "Invalid Request" #417

Open DrMcCoy opened 2 years ago

DrMcCoy commented 2 years ago

When pressing Ctrl+S on a processed image on Firefox 97.0 (on Gentoo Linux), the result is an image that says "Invalid Request", as if the produced file wasn't grabbed but instead a new request has been started.

It used to work in the past, with older Firefox versions, so it could be related to changes in Firefox.

qujohn commented 2 years ago

这是来自#@邮箱#的自动回复邮件。 您好,发送的邮件已经收到,我将尽快给您回复。感谢您的来信

1374363910 commented 2 years ago

这是章泽鑫的邮箱,我收到你的邮件了。

nagadomi commented 2 years ago

For a long time, I believe this behavior in Firefox is a bug.

  1. Firefox will try to re-fetch the image data with a GET Request before saving it.
  2. However, the output image of waifu2x is an image data generated by a POST Request with Parameters, so it is impossible to fetch it with a GET Request.

I think this behavior is completely wrong and cannot be fixed by the user.

Also, the download button should work.

DrMcCoy commented 2 years ago

Also, the download button should work.

...Huh. You know, I just utterly missed that button. You're right, the button does work.

iairu commented 9 months ago

Excuse me, I appreciate the work you do on the waifu2x project, but just wanted to ask what is the point of the Download button instead of simply having the Convert button, as the Download button doesn't do anything and Convert can simply be used to download the image right afterwards. Thank you.

nagadomi commented 9 months ago

Clicking the Download button will automatically download the result image. The image is automatically downloaded to the web browser's Download Folder without the Save As dialog box appearing.

In some browsers(Firefox or Mobile's browser), Save As feature does not work. That's why there is the download button.