Support various apple-touch-icon sizes

nagaisatoshi / mobile-bookmark-bubble

Automatically exported from code.google.com/p/mobile-bookmark-bubble

Apache License 2.0

0 stars 0 forks source link

Support various apple-touch-icon sizes #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Use an apple-touch-icon larger then 57 x 57 pixels (e.g. 129px or 512px)
2. Launch mobile-bookmark-bubble enabled page.

What is the expected output? What do you see instead?
See only top-left corner of icon in bubble :-(

What version of the product are you using? On what operating system?
iPhone 3G (iOS 4.0)

Please provide any additional information below.

Pretty easy to fix. Add the following after line 525: -

  icon.style.WebkitBackgroundSize = '57px';

Sorted!

Original issue reported on code.google.com by Leslie.Owusu.Appiah on 21 Oct 2010 at 9:06

GoogleCodeExporter commented 9 years ago

Thanks for pointing this out!

Before I can integrate your patch into the library, I need you to sign a 
Contributor License Agreement. This can be done electronically here: 
http://code.google.com/legal/individual-cla-v1.0.html

Let me know once you've signed the agreement and I'll patch this in. :)

Original comment by ntho...@google.com on 21 Oct 2010 at 12:39

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Just completed the electronic CLA.
Glad my patch is useful/was accepted; it's my first on Google Code!
Keep up the good work Neil.

Original comment by Leslie.Owusu.Appiah on 21 Oct 2010 at 3:13

GoogleCodeExporter commented 9 years ago

The patch has now been committed as changeset 4ee2e119fd. Thanks!

Original comment by ntho...@google.com on 21 Oct 2010 at 4:12

Changed state: Fixed