search

nagalun / multiplayerpiano-server

Unofficial server for the http://multiplayerpiano.com client.
https://piano.ourworldofpixels.com
ISC License
12 stars 16 forks source link

get salt from environment variable pls #35

Open ghost opened 3 years ago

ghost commented 3 years ago

u could (and probably should) use environent variables for the other options like admin password too.

Hri7566 commented 3 years ago

it should be a really easy pr to make, i think all you need is std::getenv

ghost commented 3 years ago

k

On Sun, Aug 15, 2021, 1:02 AM Hri7566 @.***> wrote:

it should be a really easy pr to make, i think all you need is std::getenv

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nagalun/multiplayerpiano-server/issues/35#issuecomment-899012411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4LCHODB2DMTPEA6FWBIK3T45X7VANCNFSM5CCM4PYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

fucksophie commented 3 years ago

i made a config.json that should be used instead tbh

Hri7566 commented 3 years ago

but that would make it commit-able to the repo, salts and db passwords and stuff should be in an environment-level config

ghost commented 3 years ago

well dont commit it then ru (gitignore)

but env variable ideal for this