search

nagarajanchinnasamy / subtotal

A JavaScript plugin for PivotTable.js. It renders subtotals of rows and columns with the ability to expand and collapse rows and columns
http://nagarajanchinnasamy.com/subtotal
MIT License
92 stars 46 forks source link

Tests don't test new functionality #1

Open nicolaskruchten opened 8 years ago

nicolaskruchten commented 8 years ago

First of all, very nice job on this packaging! I'm glad the framework from PivotTable.js was helpful :)

I notice that you've reused the test suite, which is great, but I would recommend upgrading the tests so that they actually run with your extended PivotData and Renderer, otherwise they are really just testing the core.

nagarajanchinnasamy commented 8 years ago

Thanks for being my first customer :-) ...

Good catch ;-) Its surely on my TODO list.

nagarajanchinnasamy commented 8 years ago

In master branch, added few tests for SubtotalPivotData... Will add tests for SubtotalRenderer.

nicolaskruchten commented 8 years ago

Cool! It's neat to see that the testing framework can help QA other code as well :)

nagarajanchinnasamy commented 7 years ago

Added more tests specific to subtotal plugin as part of v1.6.0. Would love to hear your feedback :)