Stashing before gitpull and applying it after may have overridden some of your changes on those files. Please look at them apply separately.
Completed tasks in this PR:
1) HandleComplaintComponent
For telephone field: Add validation for valid US phone numbers, and remove excess padding on the right of the field that’s masking the last digit.
The green button at bottom should have text: “I don’t have time right now…” if neither phone number, email or text f/b is provided. If any of these are provided, show the words “Thank you!”
I have removed auto complete email related code from files before creating PR. You may find some of them there. Please ignore them for now.
2) Rationalize the CSS across RequestReviewComponent, HandleComplaintComponent, TopInfluencerComponent and StartWithSurveyOptionComponent. There is a lot of inline styling, a lot of the stlying is repeated in multiple places. Please refactor all the styling so it looks consistent. Specific list:
Remove inline styling
Use built-in ionic sass variables
Use built-in ionic component attributes (e.g. use round for rounded buttons)
Move common styles to global scss (app.scss?)
Where ratios (e.g. em measures) are invovled, use sass variables
Please note: we have modified for RequestReviewComponent and HandleComplaintComponent but not yet moved local .scss file to global. We will move after completing for TopInfluencerComponent and StartWithSurveyOptionComponent.
Stashing before gitpull and applying it after may have overridden some of your changes on those files. Please look at them apply separately.
Completed tasks in this PR:
1) HandleComplaintComponent For telephone field: Add validation for valid US phone numbers, and remove excess padding on the right of the field that’s masking the last digit. The green button at bottom should have text: “I don’t have time right now…” if neither phone number, email or text f/b is provided. If any of these are provided, show the words “Thank you!”
I have removed auto complete email related code from files before creating PR. You may find some of them there. Please ignore them for now.
2) Rationalize the CSS across RequestReviewComponent, HandleComplaintComponent, TopInfluencerComponent and StartWithSurveyOptionComponent. There is a lot of inline styling, a lot of the stlying is repeated in multiple places. Please refactor all the styling so it looks consistent. Specific list: Remove inline styling Use built-in ionic sass variables Use built-in ionic component attributes (e.g. use round for rounded buttons) Move common styles to global scss (app.scss?) Where ratios (e.g. em measures) are invovled, use sass variables
Please note: we have modified for RequestReviewComponent and HandleComplaintComponent but not yet moved local .scss file to global. We will move after completing for TopInfluencerComponent and StartWithSurveyOptionComponent.