search

nagata-yoshiteru / pbm-ppm-pgm-viewer-for-vscode

MIT License
14 stars 9 forks source link

Request for collaboration #1

Open weiszben opened 3 years ago

weiszben commented 3 years ago

Hi! I wrote this PPM viewer for vscode earlier this year, https://github.com/BenWeisz/TinyViewer, I was wondering if you would be interested in collaborating. I could add the character formats P3, P2 for your PPM viewer. Let me know, thanks!

nagata-yoshiteru commented 3 years ago

Hello, weiszben! I'm very happy to hear your offer and I would like to collaborate with you too! Also, I saw your extension and thought that the code for displaying an image is better than mine ( you used a custom editor but I didn't ), so I would like you to share the code and improve the user experience. I would like to add you as a collaborator for this repository if you like or please open PR for adding a new feature. I'm looking forward to hearing from you. Thanks!

weiszben commented 3 years ago

Awesome! I really liked that you had a zoom feature too which I was having some trouble coming up with. Ill let you know when the PR is ready. Also, you can call me Ben 🙂

BenWeisz commented 3 years ago

Hey @nagata-yoshiteru I was wondering if you could upload some sample images into a folder like /images for example, thanks!

BenWeisz commented 3 years ago

Sorry, one more thing, I was hoping you could add this account <-- as a collaborator so I could push code to the repo. The first message I sent you was with my workplace account. Thank you!

nagata-yoshiteru commented 3 years ago

Hello, Ben! I think your suggestion looks good! I'm wondering images from the site below are suitable for sample images. https://homepages.cae.wisc.edu/~ece533/images/ I also would like you to suggest other images if you have another idea. In addition, I sent an invitation to @BenWeisz. Please check your mailbox. Thanks!

BenWeisz commented 3 years ago

Hey, thanks! Yes those look good, I think boy.ppm should be good for the P6 format I can upload some for P2 and P3

BenWeisz commented 3 years ago

I just merged the code for the custom editor set up. I think once we have the fixes for P5, P6 we can try to modify the code to separate out the code that parses the file headers.

That way we should be able to extend the code more easily to add the P2, P3 formats

nagata-yoshiteru commented 3 years ago

Thanks, Ben. I agree with your suggestion! I'm counting on you for this.

nagata-yoshiteru commented 3 years ago

Also, I would like to publish a new version (v0.0.4) at this time to release your contribution (user editor). I'll create new version if you don't mind. Thanks!

weiszben commented 3 years ago

Sounds good to me! 🙂

BenWeisz commented 3 years ago

@nagata-yoshiteru Hey I think there's just a few more things that we need to do:

I can handle the last 2 but if you dont mind doing the first one, that would be awesome! Thank you 🙂

nagata-yoshiteru commented 3 years ago

Hello, @BenWeisz! I checked the website I mentioned in #3, and added tiny code to support P2/P3 header in src/parsing.ts. The above site describes that the header for P2/P3 is the same as P5/P6, so I simply use the same parser for P2/P3. If we have another problem, let me know, and I'll fix it! Thanks!