Set Up PPM viewer using CustomEditor API

nagata-yoshiteru / pbm-ppm-pgm-viewer-for-vscode

MIT License

14 stars 9 forks source link

Set Up PPM viewer using CustomEditor API #2

Closed BenWeisz closed 3 years ago

BenWeisz commented 3 years ago

Set up PPM / PGM viewer using VSCode CustomReadOnlyEditor API

Todo:

[x] Test new api implementation with P5 and P6 Files

nagata-yoshiteru commented 3 years ago

Hello, Ben! Thank you for implementing CustomEditor API! I think your code works very well at this time. When you finish implementing this feature, please remove WIP in the title and tell me again. Thanks!

nagata-yoshiteru commented 3 years ago

Sorry, Ben. I had some trouble in my build environment and have no compile errors when I commented before. So I thought you have already finished. I implemented some fixes, and I think everything is working now. Also, I found issues with loading boy.ppm you mentioned in Issues. I'll check out from this branch and push the fix soon. Thanks!