search

nagata-yoshiteru / pbm-ppm-pgm-viewer-for-vscode

MIT License
14 stars 9 forks source link

P1 / P4 File Support #20

Closed BenWeisz closed 2 years ago

BenWeisz commented 2 years ago

I've added support for the .pbm file formats (P1/P4), as well as made some small changes to the number of bytes the parser reads so that we have a more stable parser. I've also added a few extra sample images.

Since we know support all the NetPBM formats we should probably: 1) Rename the extension to NetPBM viewer OR 2) Change the repo name to pbm-ppm-pgm-viewer-for-vscode

Let me know what you think, thanks!

BenWeisz commented 2 years ago

@nagata-yoshiteru That sounds good to me, we can bump the verson! I've tried to add the pbm to a few places but there might be some that are missing.

Thanks for the review :)

nagata-yoshiteru commented 2 years ago

@BenWeisz Thanks for your quick reply!

I will update the repo name, package.json and double check to add "pbm" ! However, I think we should not change the extension's identifier ( ppm-pgm-viewer-for-vscode ) because we will fail to publish the extension once we change it, so I will leave it as it is.

Thanks!

nagata-yoshiteru commented 2 years ago

@BenWeisz I updated repo name, and double checked to add "pbm" ( and there is no missing point! ) Also, I bumped version up to 1.0.0!

If there are no problem, I will merge this PR and publish new version! Thanks!

BenWeisz commented 2 years ago

Awesome! Feel free to publish it :)