search

nager / Nager.Country

Worldwide Country Informations (ISO-3166-1 Alpha2, ISO-3166-1 Alpha3, ISO 639-1)
MIT License
114 stars 23 forks source link

Please add country code information for XK #14

Closed AlexKulbako closed 2 years ago

AlexKulbako commented 2 years ago

Your library cannot be used for production purposes as it does not support all country codes ...

tinohager commented 2 years ago

What countries are all missing from your point of view?

tinohager commented 2 years ago

https://en.wikipedia.org/wiki/International_recognition_of_Kosovo

I think as long as there is no clear recognition of this, it will remain as it is.

AlexKulbako commented 2 years ago

Thank you for the answer. Agree with that. It is also not available in iso3166.

amirvenus commented 2 years ago

https://en.wikipedia.org/wiki/International_recognition_of_Kosovo

I think as long as there is no clear recognition of this, it will remain as it is.

I think it would be great to have it added as I would love to use this for production and some of my clients are [oddly] based in Kosovo.

Also, on the missing note, there are some phone calling codes missing which I have extracted myself based on a research (so that all UTs can pass):

                             ```
                             "AQ" => "672",
                "BV" => "55",
                "TF" => "262",
                "HM" => "0",
                "UM" => "246",
SentinelBorg commented 1 year ago

I also wished Kosovo (XK/XKX) would be added. I get that code from SAP and other systems in Swiss hospitals all the time.

tinohager commented 1 year ago

https://en.wikipedia.org/wiki/International_recognition_of_Kosovo

I think as long as there is no clear recognition of this, it will remain as it is.

SentinelBorg commented 1 year ago

https://en.wikipedia.org/wiki/International_recognition_of_Kosovo I think as long as there is no clear recognition of this, it will remain as it is.

But it is recognized in most Western Countries and because of all the migrants from that area also widely used in for example Switzerland, Germany and probably also Austria. Maybe mark it as "temporary/unofficial" and extent the two Get() methods with an optional parameter/flags to also consider those if the users wishes so.

tinohager commented 1 year ago

Nager.Country is based on Iso3166

Kosovo is disputed under international law. 115 of the 193 UN members have recognized Kosovo to date. "X" codes such as perhaps "XK" or "XXK," etc., are private, non-authoritative assignments. ISO codes do not exist to date.

wstaelens commented 3 months ago

XK is in https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

ISO 3166-1 alpha-2 codes are two-letter country codes defined in ISO 3166-1, part of the ISO 3166 standard[[1]](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#cite_note-iso3166-info-1) published by the International Organization for Standardization (ISO), to represent countries, dependent territories, and special areas of geographical interest.

The code XK is being used by the European Commission[28] the IMF, and SWIFT,[29] the CLDR, and other organizations as a temporary country code for Kosovo.[30]

Looks like it is part of ISO 3166.... as ISO 3166-1_alpha-2 is part of ISO 3166.