search

nager / Nager.Date

Worldwide holidays (REST API), NuGet or docker container :earth_americas:
https://date.nager.at
MIT License
1.09k stars 176 forks source link

Brazil Carnival #194

Closed dimmuboy closed 4 years ago

dimmuboy commented 4 years ago

Important specifications

Brazil https://www.officeholidays.com/countries/brazil/2020 https://www.officeholidays.com/holidays/brazil/brazil-carnival

Description

Why is 24th February 2020 is not present? It's a bank holiday too.

image

tinohager commented 4 years ago

I can not found Carnival on wikipedia, the main source for this project is the wikipedia page https://en.wikipedia.org/wiki/Public_holidays_in_Brazil

dimmuboy commented 4 years ago

So it's look like wikipedia is wrong. I mean that I can more believe to Central bank of Brazil and my brazil colleagues. We have few projects in UiPath that depends on Nager.Date and it fails because tried to find rates data in bank website on holiday :/ It will be great if you can fix it.

tinohager commented 4 years ago

I would add the additional tag immediately if Wikipedia accepts the change. It is not possible to collect the holidays for each country on different websites. I hope you can understand this.

dimmuboy commented 4 years ago

I'm sorry but I can't understand. Why you need some confirmation from wikipedia page when 25th Feb is not on wiki too but in your public holidays list it is? BTW Brazil Central bank is much more relevant than some wikipedia page.

laloune commented 4 years ago

personally I understand @tinohager since the information has to be unified (this is so to say the goal of his api)

just change wikipedia according to your source like I did in the past in the issue #84