search

nager / Nager.Date

Worldwide holidays (REST API), NuGet or docker container :earth_americas:
https://date.nager.at
MIT License
1.06k stars 171 forks source link

Australia - Easter Sunday missing for some states #608

Closed pdegenhardt closed 3 months ago

pdegenhardt commented 3 months ago

Affected country

Australia

Affected public holiday

Easter Sunday

Source of the information

https://www.qld.gov.au/recreation/travel/holidays/public

More information

All states have nominated Easter Sunday as a public holiday. E.g. Queensland link shown above.

The API incorrectly provides the date only for: ACT, NSW, VIC and WA.

It is currently national, so the simplest fix would seem to be to simply remove the 'Counties' specification.

tinohager commented 3 months ago

hat would mean that from 2017 the holiday should apply to the whole of australia

https://github.com/nager/Nager.Date/blob/89ece8f08542c4dd7c46b7190542dcd493b5ec69/src/Nager.Date/HolidayProviders/AustraliaHolidayProvider.cs#L231-L244

tinohager commented 3 months ago

I have check this source -> https://www.fairwork.gov.au/employment-conditions/public-holidays

ACT NSW NT QLD SA TAS VIC WA
2021 ✓ ✓ - ✓ - - ✓ -
2022 ✓ ✓ - ✓ - - ✓ ✓
2023 ✓ ✓ ✓ ✓ - - ✓ ✓
2024 ✓ ✓ ✓ ✓ ✓ - ✓ ✓
2025 ✓ ✓ ✓ ✓ ✓ - ✓ ✓

It looks in Tasmania Easter Sunday is not a public holiday. Addition: with the waybackMachine i add the info for 2022 and 2021

pdegenhardt commented 3 months ago

Wow! I actually live in Tasmania and I had no idea. How bizarre!

tinohager commented 3 months ago

Hi, i have push a pull request can you check it please

pdegenhardt commented 3 months ago

Looks good to me. Thanks.

tinohager commented 3 months ago

i have published a new version