Argentina - Wrong public holiday

nager / Nager.Date

Worldwide holidays (REST API), NuGet or docker container :earth_americas:

https://date.nager.at

MIT License

1.12k stars 179 forks source link

Argentina - Wrong public holiday #685

Closed JuanIgnacioPayo closed 2 weeks ago

JuanIgnacioPayo commented 1 month ago

Affected country

Argentina

Affected public holiday

many holidays

Source of the information

https://www.argentina.gob.ar/interior/feriados-nacionales-2024

More information

There are many affected holidays, please check the dates with the provided official link https://www.argentina.gob.ar/interior/feriados-nacionales-2024. Thank you

tinohager commented 1 month ago

I am happy to correct errors, but please name specific holidays where errors exist. Then we can also fix them. But simply sending a list is unfortunately not the way we work here.

JuanIgnacioPayo commented 1 month ago

Hi Tino, good afternoon, thank you very much for your quick response.

I didn't specify much before because I didn't know how it worked, I apologize. Below I will indicate the dates on which the official Argentine government calendar differs from the holiday calendar of your API.

Thank you very much for the service you provide and the responsibility with which you work.

Monday, April 1st was a holiday bridge for tourism purposes.
Friday, June 21st was a holiday bridge for tourism purposes.
August 17th fell on a Saturday and the holiday was not moved.
Therefore August 19th was not a holiday.
Monday, October 14th is not a holiday.
The holiday on Saturday, October 12th was moved to Friday, October 11th.
Sovereignty Day is on November 20th but since it fell on a Wednesday, they decided to move it to Monday, November 18th.

tinohager commented 1 month ago

@JuanIgnacioPayo The public holidays should now fit better, the “tourist public holidays” would require a manual entry every year. I have not yet dealt with this.

JuanIgnacioPayo commented 1 month ago

Thank you very much Tino! Your job was great. Now i can work whit this much better. Please indicate me where i can buy you a virtual coffee. Have a nice day

El mié, 2 de oct de 2024, 10:18 a. m., Tino Hager @.***> escribió:

@JuanIgnacioPayo https://github.com/JuanIgnacioPayo The public holidays should now fit better, the “tourist public holidays” would require a manual entry every year. I have not yet dealt with this.

— Reply to this email directly, view it on GitHub https://github.com/nager/Nager.Date/issues/685#issuecomment-2388625042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVFECBBG2FFUBTWRQPA3EI3ZZPXCHAVCNFSM6AAAAABOWW4G6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGYZDKMBUGI . You are receiving this because you were mentioned.Message ID: <nager/Nager .@.***>

pmxgit commented 1 month ago

Hello,

I want to report an issue with this Holiday API for Argentina 2024: https://date.nager.at/api/v3/PublicHolidays/2024/AR

In this API we have duplicated a holiday at February 12 for 2024

"date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]},{"date":"2024-02-12","localName":"Carnaval","name":"Carnival","countryCode":"AR","fixed":false,"global":true,"counties":null,"launchYear":null,"types":["Public"]}

We have 2 days for Carnaval and they are February 12 and February 13.

I will apreciate if you can change this.

Thank you very much!

tinohager commented 1 month ago

@pmxgit I have revised the rules again.