search

nager / Nager.PublicSuffix

.NET public suffix domain parser
MIT License
155 stars 22 forks source link

This commit fixed #30 #32

Closed gokayokutucu closed 5 years ago

gokayokutucu commented 5 years ago

Don't need to check protocol. Validation of the url is enough to catch specific exception.

gokayokutucu commented 5 years ago

I have added some methods that provides to resolve original url from the shortened url like "https://bit.ly/325uzsF".

tinohager commented 5 years ago

Your pull reuest have some errors unit tests have some errors, syntax conventions has been disregarded, please add more information about your fix. Thanks

gokayokutucu commented 5 years ago

Yes, you are right. The test project is not build on macOS and auto-formatter(beautycode) is active on VsCode. I will consider your syntax convention next time.

Is it possible to update the unit test project on .net standart library with xUnit?

gokayokutucu commented 5 years ago

I tried to update the Unit Test library with xUnit. But I have some error in DomainNameTestsWithIdnMappingNormalization and PublicSuffixTestsWithIdnMappingNormalization unit test files. That is your code, so maybe you can fix the other problems.

Otherwise I will discard changes.

Good luck!