nagi1 / hill-chart

Basecamp's hill chart implementation in d3.js
MIT License
50 stars 18 forks source link

dependency updates #42

Open savar opened 6 months ago

savar commented 6 months ago

trying to update all relevant dependencies to have no audit issues anymore

see issue #41

savar commented 6 months ago

Please be aware, I am no expert in Javascript's world of madness. I tried to update as good and as sane as I could but honestly I am just poking in the dark.

Somebody with much more experience should have a look regarding the changes, if they do make sense or not!

savar commented 6 months ago

Anything required from my end to get this checked and maybe merged/deployed?

nagi1 commented 5 months ago

Hey thank you so much for taking the time to take care of this.

But I can't merge pr that we are not sure about, im really struggling to find time to do it. Can we rely on other community members to look at this?

savar commented 5 months ago

Hey thank you so much for taking the time to take care of this.

But I can't merge pr that we are not sure about, im really struggling to find time to do it. Can we rely on other community members to look at this?

I would love to help, but I am normally not running in the JavaScript world. Maybe you know someone. I can only tell you, that it seems to work fine and the test work.

savar commented 2 months ago

Any plans to merge this? In the worst case, we can release this with a major version jump so that no one is using it without being aware of the potential issue that it might break (though the tests and my local system say otherwise)?