windows: make windows-sys dev-dependency target-specific

nagisa / rust_libloading

Bindings around the platform's dynamic library loading primitives with greatly improved memory safety.

https://docs.rs/libloading

ISC License

1.24k stars 102 forks source link

windows: make windows-sys dev-dependency target-specific #140

Closed decathorpe closed 8 months ago

decathorpe commented 8 months ago

The windows-sys dependency is only relevant on cfg(windows) targets.

nagisa commented 8 months ago

This looks like an improvement to me, but I want to know in what instance does a dev-dependency being unconditional actually makes the dependency to get pulled in outside of the scenarios where somebody develops libloading itself? Is there any?

decathorpe commented 8 months ago

We try to run cargo test for all Rust crates we package for Fedora Linux. I know that Debian is doing something similar.

nagisa commented 8 months ago

Alright, thank you for the contribution!

decathorpe commented 8 months ago

Thanks for merging!

nagisa commented 8 months ago

This is now on crates.io as 0.8.3.