search

nagix / chartjs-plugin-colorschemes

Predefined color schemes for Chart.js
MIT License
271 stars 59 forks source link

Fix v3 compatibilities #34

Open zsu opened 2 years ago

zsu commented 2 years ago

Changes to fix v3 compatibilities. 'override' is renamed to 'overrideExisting' since override is a function in v3.

seanhamlin commented 2 years ago

Actual lifesaver. This PR works great.

m08pvv commented 2 years ago

When this PR will be merged? It would be awesome to have it in the npm package

igorlukanin commented 1 year ago

@nagix Any chance you can take a look at this one, merge, and release it? I'd like to mention it as a Chart.js v3-compatible, working one in Chart.js docs on colors: https://github.com/chartjs/Chart.js/pull/10764#discussion_r995178312

homestar9 commented 10 months ago

@zsu excellent work with the fixes for V3! @m08pvv, I appreciate you pushing up your NPM package! I mentioned it in the Issues area here to help others find it: https://github.com/nagix/chartjs-plugin-colorschemes/issues/38

FYI, I'm sure you both already know, but the fixes for V3 don't work with V4 for some reason. I tried to take a stab at it, but I can't figure out why the plugin won't register globally. I don't see any breaking changes that would cause it to cease working.