What steps will reproduce the problem?
1. Attempt to build openspin on Linux using GCC
2. There are various Makefile problems
3. openspin fails to link at the final stage
What is the expected output? What do you see instead?
A successful build should result in generation of the openspin binary.
openspin fails at the linking stage.
What version of the product are you using? On what operating system?
Revision 69 on Fedora and Arch Linux.
Please provide any additional information below.
The link fail problem is caused by specifying -static in the CFLAGS/CXXFLAGS.
It is not required and breaks the link stage.
Additionally specifying -g in CFLAGS/CXXFLAGS only makes the objects and
executable larger. It is better to optimize using -O2 which is standard
practice.
The top-level Makefile clean target should not remove the library. The library
Makefile clean target does this already.
The use of -rf in the clean target is unnecessary as all files are explicitly
specified. It is sufficient to use -f only to suppress errors for non-existent
files.
Patches are attached.
Tested with Fedora 20 using gcc-4.8.2 and Arch Linux using gcc-4.9.0
(pre-release).
Original issue reported on code.google.com by neil.dar...@gmail.com on 30 May 2014 at 2:50
Original issue reported on code.google.com by
neil.dar...@gmail.comon 30 May 2014 at 2:50Attachments: