nagyistoce / open-source-spin-compiler

Automatically exported from code.google.com/p/open-source-spin-compiler
0 stars 0 forks source link

stricmp/strcasecmp implementation is reversed #29

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. GCC >= 4.8 should use strcasecmp not stricmp.
2.
3.

What is the expected output? What do you see instead?
openspin should build without errors relating to stricmp being undefined.
openspin build fails in two files due to stricmp being substituted for 
strcasecmp.

What version of the product are you using? On what operating system?
Revision 69 on Fedora and Arch Linux.

Please provide any additional information below.
GCC >= 4.8 does not provide stricmp in string.h. strcasecmp should be used 
instead. The substitution macro in PropellerCompiler/PropellerCompiler.h has 
the function definitions the wrong way around.

Patch attached.
Tested on Fedora 20 using gcc-4.8.2 and Arch Linux using gcc-4.9.0 
(pre-release).

Original issue reported on code.google.com by neil.dar...@gmail.com on 30 May 2014 at 2:56

Attachments: