nagyistoce / tin-man

Automatically exported from code.google.com/p/tin-man
GNU General Public License v3.0
0 stars 0 forks source link

Heard messages from opponents can crash agents #33

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
During the IranOpen 2012, a match against Nexus3D saw the TinMan-based agents 
disappear during the game.  The issue seems to be that received messages are 
not considered valid by the Message.IsValid method, which then raises an 
unchecked exception.

1. The validation method must be incorrect, as the server processes messages 
that TinMan rejects (maybe the documentation is wrong too) which means the 
range of messages TinMan could send is unnecessarily limited.

2. Heard messages should not cause exceptions to be raised, as this is an 
uncontrollable threat against TinMan agents.

Original issue reported on code.google.com by drewnoakes on 19 Apr 2012 at 10:57

GoogleCodeExporter commented 9 years ago
I've moved the line that throws the exception from the Message constructor into 
the Say method.  This means we will only validate outbound messages and not 
inbound ones.

Original comment by drewnoakes on 20 Apr 2012 at 11:15

GoogleCodeExporter commented 9 years ago

Original comment by drewnoakes on 20 Apr 2012 at 11:37