search

nahanni / rw_redis_fdw

Other
96 stars 23 forks source link

redis "KEYS *" command? #4

Closed josmac69 closed 8 years ago

josmac69 commented 8 years ago

Hi. I tested your fdw and it is really really good. Only thing I was not able to simulate is redis " KEYS * " command which gives me list of existing keys. Or KEYS "key-name*" which would be extremaly helpful. Would it be possible to implement it somehow? Maybe in similar way like LEN command... Thanks.

l-d-x commented 8 years ago

I will take a look at implementing this. It isn't particularly difficult; I didn't implement it originally because the key space could be particularly large with the various data types involved.

schinckel commented 8 years ago

It's also worth pointing out that KEYS * is generally not a good idea: it can really bring your redis server to it's knees.

http://stackoverflow.com/a/5252511/188

http://redis.io/commands/keys

josmac69 commented 8 years ago

Yes, you are right. But we have use case for this and data volume is not that big. Cheers

l-d-x commented 8 years ago

Commit https://github.com/nahanni/rw_redis_fdw/commit/0e039f4b0ef565e1d4114228199076295a15ead1