nahi / httpclient

'httpclient' gives something like the functionality of libwww-perl (LWP) in Ruby.
https://github.com/nahi/httpclient
703 stars 290 forks source link

Update travis config #424

Closed mrpasquini closed 3 years ago

mrpasquini commented 4 years ago

I suspect a rebuild on the main branch will currently fail so attempting to get a green build on this PR.

mrpasquini commented 4 years ago

The test_no_sslv3 test seems to raise either:

I can reproduce the pass on 2.5.8 locally and the failure on 2.5.3 locally so it likely depends on the Ruby & OpenSSL versions installed.

I've added a commit to catch this Errno::ECONNRESET error during connection setup and reraise as an OpenSSL::SSL::SSLError, thought I am not sure that is the correct approach and would appreciate feedback.

It looks like WEBrick might be throwing a segfault.

mrpasquini commented 4 years ago

Project does not seem active, closing this PR

nahi commented 3 years ago

Sorry for the late response. The fix is correct, the error happens when underlying openssl does not allow to use SSLv3 (server does not start.) I marked this test as omit until we disable TLSv1 and reuse the test. Thanks for the patch.