search

nahid / imapx

imapx is php library for laravel 5. Its retrieve all emails from server via imap or pop
MIT License
11 stars 8 forks source link

private to protected #8

Closed shoomilka closed 7 years ago

shoomilka commented 7 years ago

I have a problem to create dynamically configurated email-parser on Laravel (configurations from my DB, not from config file), so I tried to inherit your Imapx (add a constuctor with parameters), but private variables don't allowed to changing using inheritation.((( So I think would be better to change private to protected. I don't know it is necessary for imapxPHP.php or not, but for Laravel version this fix will be good, I think.

nahid commented 7 years ago

Thank you @shoomilka for this important PR.

shoomilka commented 7 years ago

Thank you too :+1: