search

nahid / talk

Talk is a real-time users messaging and chatting system for Laravel.
MIT License
1.61k stars 326 forks source link

Fixed a typo on Talk.php #116

Open naifmhd opened 6 years ago

naifmhd commented 6 years ago

the relationship was conversation but it was written as coversation.

ndhaked commented 6 years ago

i need to delete messages from one sided like as facebook delete for me only..

nahid commented 6 years ago

One side soft delete feature is already implemented

ndhaked commented 6 years ago

Hello Sir, I want to delete like as Facebook if sender delete conversation then on sender side deleted all messages and conversation but another side will be same like as old. its not implemented

On Tue, Jun 12, 2018 at 9:51 AM, Nahid Bin Azhar notifications@github.com wrote:

One side soft delete feature is already implemented

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nahid/talk/pull/116#issuecomment-396461228, or mute the thread https://github.com/notifications/unsubscribe-auth/AcCnKSczsagmqJXEPKCl40Ym29lbkWyNks5t70HIgaJpZM4SmTnC .

--

RegardsNirbhay Singh Dhaked

Sr. Php Developer Konstant infosolutions pvt.ltd

Jaipur (Rajasthan) 302020Cont:- 9269967182

peter279k commented 6 years ago

@ndhaked, I think that it doesn't matter. Just add the latest commit to fix $this->config request changes as @nahid says. The Git can squash all to one commit and it can also use the merging approach when merging the PR.

Thanks.

cfpinto commented 5 years ago

@naifmhd could you please do the changes that @nahid requested? We would like to merge the PR