baksmali doesn't work on Windows 8.1

nahidupa / smali

Automatically exported from code.google.com/p/smali

0 stars 0 forks source link

baksmali doesn't work on Windows 8.1 #234

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

What seems to be the problem?
When trying to run baksmali on Windows 8.1, it just outputs "test" to the 
command line and then hangs.

What is the exact smali/baksmali command that you ran?
java -jar baksmali-2.0.3.jar -a 19 -d framework -x telephony-common.odex

What version of smali/baksmali are you using? What rom are you working
from?
baksmali versions 2.0.3 and 2.0.5. ROM is v50020d for the LG G Pad 8.3.

What is the airspeed velocity of an unladen swallow?
~11 meters per second.

Please provide any additional information below: error messages, symptoms,
etc.
Problem seems to lie in the "testForWindowsReservedFileNames" method, which on 
Windows 8.1 outputs "test" to the command line, instead of failing.

Original issue reported on code.google.com by hecri...@gmail.com on 1 Mar 2015 at 7:55

GoogleCodeExporter commented 9 years ago

Thanks for the report! I think this basically prevents baksmali from working at 
all on windows 8.1.

Windows 8.1 has some behavior changes related to creating a file with a 
reserved filename. In previous versions of windows, attempting to create a file 
like "con" or even "con.smali" would fail. In windows 8.1, trying to create 
such a file succeeds, although it doesn't actually create the file. Instead, it 
opens the existing con device.

Original comment by jesusfreke@jesusfreke.com on 1 Mar 2015 at 9:37

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

This should be fixed by ea4074fdccb2. hecristi - Can you grab and build the 
source, and see if it fixes the problem? (see: 
https://code.google.com/p/smali/wiki/BuildProcedure)

Original comment by jesusfreke@jesusfreke.com on 2 Mar 2015 at 6:56

GoogleCodeExporter commented 9 years ago

I tried building the source according to the instructions, but it failed for 
some reason. Here is the output, in case you're interested: 
http://pastebin.com/zs6vpimr

It created the baksmali jar anyway, though, and with my tests it seems to work 
just fine, so I'd say the initial problem is fixed.

Original comment by hecri...@gmail.com on 2 Mar 2015 at 5:51

GoogleCodeExporter commented 9 years ago

Great, thanks! I'll probably fix that one build failure (which happens if you 
don't have the "dx" tool on-path), and make a new release, since this is a 
fairly high-severity issue with no workaround.

Original comment by jesusfreke@jesusfreke.com on 2 Mar 2015 at 7:14