nahmii-community / bridge

The Nahmii gateway, for bridging assets between L1 <-> L2.

1 stars 2 forks source link

Integrate deposit and withdrawals through the @Nahmii/SDK #52

Closed HDauven closed 2 years ago

HDauven commented 2 years ago

Purpose Use the newly created @nahmii/SDK package for deposits and withdrawals.

Issues

47

Changes

Fix a number parsing bug that occurs in the token selection process.
Refactor use of internal depositETH and depositERC20 functions.
Use the SDKs initiateWithdrawal function instead of the internal withdraw function.
Remove unused deposit and withdrawal functions.
Remove contract metadata that is no longer used.
Update the @nahmii/SDK package.

Check list

[x] Code runs without regressions even though new code is incomplete
[x] Code reviewer has been explicitly notified outside automatic notification channels