nahsra / WebGoat_12_23

Other
0 stars 2 forks source link

Split variable declarations into their own statements (Sonar) #7

Closed pixeebot[bot] closed 6 months ago

pixeebot[bot] commented 6 months ago

This change splits variable assignments onto their own lines. Many sources believe it is easier to review code where the variables are separate statements on their own individual line.

Our changes look something like this:

-   int i = 0, limit = 10;
+   int i = 0;
+   int limit = 10;

    while (i < limit){
More reading * [https://rules.sonarsource.com/java/RSPEC-1659/](https://rules.sonarsource.com/java/RSPEC-1659/) * [https://wiki.sei.cmu.edu/confluence/display/java/DCL52-J.+Do+not+declare+more+than+one+variable+per+declaration](https://wiki.sei.cmu.edu/confluence/display/java/DCL52-J.+Do+not+declare+more+than+one+variable+per+declaration)

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

Powered by: pixeebot (codemod ID: sonar:java/declare-variable-on-separate-line-s1659)

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pixeebot[bot] commented 6 months ago

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.